Update configure_multi_stage_inputs.jl #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbonaldo
force-pushed
the
sambuddhac-patch-4
branch
from
1743739 to
de926b1
Compare
lbonaldo
force-pushed
the
sambuddhac-patch-4
branch
2 times, most recently
from
1d9a0e9 to
d9638c6
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
25
to
34
| inv_costs_yr::Array, | ||
| crp::Array, | ||
| tech_wacc::Array) | ||
|
|
||
| # Check for resources with non-zero investment costs and a Capital_Recovery_Period value of 0 years | ||
| if any((crp .== 0) .& (inv_costs_yr .> 0)) | ||
| msg = "You have some resources with non-zero investment costs and a Capital_Recovery_Period value of 0 years. " * | ||
| "These resources will have a calculated overnight capital cost of \$0. Correct your inputs if this is a mistake." | ||
| error(msg) | ||
| end |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| inv_costs_yr::Array, | |
| crp::Array, | |
| tech_wacc::Array) | |
| # Check for resources with non-zero investment costs and a Capital_Recovery_Period value of 0 years | |
| if any((crp .== 0) .& (inv_costs_yr .> 0)) | |
| msg = "You have some resources with non-zero investment costs and a Capital_Recovery_Period value of 0 years. " * | |
| "These resources will have a calculated overnight capital cost of \$0. Correct your inputs if this is a mistake." | |
| error(msg) | |
| end | |
| inv_costs_yr::Array, | |
| crp::Array, | |
| tech_wacc::Array) | |
| # Check for resources with non-zero investment costs and a Capital_Recovery_Period value of 0 years | |
| if any((crp .== 0) .& (inv_costs_yr .> 0)) | |
| msg = "You have some resources with non-zero investment costs and a Capital_Recovery_Period value of 0 years. " * | |
| "These resources will have a calculated overnight capital cost of \$0. Correct your inputs if this is a mistake." | |
| error(msg) | |
| end |
| cur_stage = settings_d["CurStage"] # Current model | ||
| num_stages = settings_d["NumStages"] # Total number of model stages | ||
| stage_lens = settings_d["StageLengths"] | ||
|
|
||
| # 1) For each resource, find the minimum of the capital recovery period and the end of the model horizon | ||
| # Total time between the end of the final model stage and the start of the current stage | ||
| model_yrs_remaining = sum(stage_lens[cur_stage:end]) | ||
| model_yrs_remaining = sum(stage_lens[cur_stage:end]; init=0) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| model_yrs_remaining = sum(stage_lens[cur_stage:end]; init=0) | |
| model_yrs_remaining = sum(stage_lens[cur_stage:end]; init = 0) |
Comment on lines
52
to
53
| occ[i] = sum(inv_costs_yr[i] / (1 + tech_wacc[i]) .^ (p) | ||
| for p in 1:payment_yrs_remaining[i]) | ||
| for p in 1:payment_yrs_remaining[i]; init=0) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| occ[i] = sum(inv_costs_yr[i] / (1 + tech_wacc[i]) .^ (p) | |
| for p in 1:payment_yrs_remaining[i]) | |
| for p in 1:payment_yrs_remaining[i]; init=0) | |
| occ[i] = sum( | |
| inv_costs_yr[i] / (1 + tech_wacc[i]) .^ (p) | |
| for p in 1:payment_yrs_remaining[i]; | |
| init = 0) |
lbonaldo
force-pushed
the
sambuddhac-patch-4
branch
from
2981978 to
6c2669d
Compare
Comment on lines
52
to
53
| occ[i] = sum(inv_costs_yr[i] / (1 + tech_wacc[i]) .^ (p) | ||
| for p in 1:payment_yrs_remaining[i]) | ||
| for p in 1:payment_yrs_remaining[i]; init = 0) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| occ[i] = sum(inv_costs_yr[i] / (1 + tech_wacc[i]) .^ (p) | |
| for p in 1:payment_yrs_remaining[i]) | |
| for p in 1:payment_yrs_remaining[i]; init = 0) | |
| occ[i] = sum( | |
| inv_costs_yr[i] / (1 + tech_wacc[i]) .^ (p) | |
| for p in 1:payment_yrs_remaining[i]; | |
| init = 0) |
Comment on lines
53
to
55
| inv_costs_yr[i] / (1 + tech_wacc[i]) .^ (p) | ||
| for p in 1:payment_yrs_remaining[i]; | ||
| init = 0) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| inv_costs_yr[i] / (1 + tech_wacc[i]) .^ (p) | |
| for p in 1:payment_yrs_remaining[i]; | |
| init = 0) | |
| inv_costs_yr[i] / (1 + tech_wacc[i]) .^ (p) | |
| for p in 1:payment_yrs_remaining[i]; | |
| init = 0) |
lbonaldo
force-pushed
the
sambuddhac-patch-4
branch
from
6400edb to
939080b
Compare
lbonaldo
pushed a commit
that referenced
this pull request
Apr 17, 2024
Add check on capital recovery period with non-zero investment cost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With introduction of init = 0 in summation terms to fix for bug encountered when summing over an empty array
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Checklist
How this can be tested
Post-approval checklist for GenX core developers
After the PR is approved